unified-runtime icon indicating copy to clipboard operation
unified-runtime copied to clipboard

[NATIVECPU] Fix coverity warnings when handling reqd_work_group_size

Open PietroGhg opened this issue 1 year ago • 2 comments

This PR fixes some new coverity warnings reported in the Native CPU adapter:

  • mdNode is defined with const auto& to avoid copies
  • hProgram uses unique_ptr to avoid leaks if we return early

This PR also adds the inclusion of <array> in program.hpp, fixing a build error on Windows. llvm PR: https://github.com/intel/llvm/pull/13805

PietroGhg avatar May 16 '24 12:05 PietroGhg

@PietroGhg all code owners must have approved PR's before adding the ready to merge label.

kbenzie avatar May 22 '24 15:05 kbenzie

@PietroGhg all code owners must have approved PR's before adding the ready to merge label.

sorry @kbenzie, got all the approvals now

PietroGhg avatar May 23 '24 09:05 PietroGhg