unified-runtime icon indicating copy to clipboard operation
unified-runtime copied to clipboard

[L0] Refactoring of boolean event parameters

Open winstonzhang-intel opened this issue 1 year ago • 4 comments

CI in LLVM/SYCL: https://github.com/intel/llvm/pull/14536

winstonzhang-intel avatar May 14 '24 01:05 winstonzhang-intel

Hello @winstonzhang-intel ,

Please rebase since there are L0 CTS failures here: https://github.com/oneapi-src/unified-runtime/actions/runs/9651142091/job/26618341665?pr=1600.

nrspruit avatar Jul 03 '24 20:07 nrspruit

@winstonzhang-intel Please make sure that https://github.com/intel/llvm/pull/14536 is updated and passing CI, so we could merge this. Thanks!

omarahmed1111 avatar Sep 17 '24 11:09 omarahmed1111

I removed the ready to merge label temporarily until the intel/llvm side is updated and passing tests. Please readd it when intel/llvm PR is updated.

omarahmed1111 avatar Sep 18 '24 07:09 omarahmed1111

I removed the ready to merge label temporarily until the intel/llvm side is updated and passing tests. Please readd it when intel/llvm PR is updated.

I removed the ready to merge label temporarily until the intel/llvm side is updated and passing tests. Please readd it when intel/llvm PR is updated.

Working on rebasing against latest phase 2 of counterbased patch.

winstonzhang-intel avatar Sep 19 '24 21:09 winstonzhang-intel

@winstonzhang-intel , please resolve the merge conflicts with a rebase otherwise the changes look good.

nrspruit avatar Dec 02 '24 20:12 nrspruit

@winstonzhang-intel unfortunately I had to revert this due to the CI failures on https://github.com/intel/llvm/pull/14536, they are very confusing to me.

kbenzie avatar Feb 12 '25 10:02 kbenzie

This could be related to https://github.com/intel/llvm/pull/16747#issuecomment-2652441043 which I think should have been resolved by https://github.com/oneapi-src/unified-runtime/pull/2690 but will need to investigate further.

kbenzie avatar Feb 12 '25 10:02 kbenzie

This could be related to intel/llvm#16747 (comment) which I think should have been resolved by #2690 but will need to investigate further.

Sounds good, please let me know. Thanks.

winstonzhang-intel avatar Feb 12 '25 21:02 winstonzhang-intel