unified-runtime icon indicating copy to clipboard operation
unified-runtime copied to clipboard
verified publisher icon oneapi-src

[L0] Fix usm allocation functions when alignment is not a power of 2

Open lbushi25 opened this issue 1 year ago • 4 comments

The Level Zero USM allocation functions are returning non-null pointer values when the alignment is not a power of two which contradicts the spec requirements. This PR fixes that. For more info, see https://github.com/intel/llvm/issues/12638

lbushi25 avatar May 01 '24 19:05 lbushi25

Hello @lbushi25 ,

Please file a Draft PR in intel/llvm pointing to this change such that the pre-commit CI in intel/llvm e2e can be run.

I did not see anything directly that was an issue, but please add that PR with this PR mentioned in the commit message. Thank you for your time and contribution!

nrspruit avatar May 13 '24 21:05 nrspruit

Hi @nrspruit , I've already opened an intel/llvm PR here https://github.com/intel/llvm/pull/13631 but looks like I forgot to mention it here.

lbushi25 avatar May 13 '24 23:05 lbushi25

Hi @nrspruit , I've already opened an intel/llvm PR here intel/llvm#13631 but looks like I forgot to mention it here.

Thank you, can you rebase your changes here and in the intel/llvm PR? Since the intel/llvm PR has a merge conflict. Otherwise looks good to me and I can approve. Thank you for your contribution.

nrspruit avatar May 13 '24 23:05 nrspruit

Hi @nrspruit , I've already opened an intel/llvm PR here intel/llvm#13631 but looks like I forgot to mention it here.

Thank you, can you rebase your changes here and in the intel/llvm PR? Since the intel/llvm PR has a merge conflict. Otherwise looks good to me and I can approve. Thank you for your contribution.

Yes, the rebase is done. I will change the UR tag on the intel/llvm PR once this is approved and merged.

lbushi25 avatar May 13 '24 23:05 lbushi25