unified-runtime icon indicating copy to clipboard operation
unified-runtime copied to clipboard

Ignore particular files for CI runs

Open martygrant opened this issue 1 year ago • 4 comments

I recently created two PRs (#1508 and #1509) which were simple changes to .github/labeler.yml which triggered the full CI pipeline. These have no effect on UR spec/source code at all so the CI running was just a waste of time and electricity.

I propose adding an ignore section to our workflow files to avoid this in future:

on:
   push:
      paths-ignore:
         - '**/<dir-path>/**'

This can include anything not involved in building UR, such as the labeler config mentioned above, CODEOWNERs file, text/markdown files.

@pbalcer Benie mentioned this might have been discussed with your team in the past. What do you think?

martygrant avatar Apr 11 '24 12:04 martygrant

Hm, I don't recall anything. I think we've talked about doing the reverse - only triggering adapter-specific CI workflows if that adapter changes. But I'm not sure if we ever did anything in that direction. @lukaszstolarczuk ping.

pbalcer avatar Apr 11 '24 12:04 pbalcer

I might be misremembering things TBH.

kbenzie avatar Apr 11 '24 12:04 kbenzie

I also don't remember discussing this, but in general I agree that we can do such an update. We may save just a little of the machines' time, but I believe it's worth it.

To get a little technical here, we'd have to get this included in almost all of our workflows (for both push and PR triggers). Perhaps there's a way to set the list once and re-use it between different workflow files...? If not, then we should define it well, before we start copy-pasting it 😉

lukaszstolarczuk avatar Apr 11 '24 12:04 lukaszstolarczuk

@pbalcer maybe your way could be better - only code/spec changes.

@lukaszstolarczuk I know in Gitlab you can include other CI config files so you could have a ignored_files.yml file and include it from e.g. cmake.yml maybe we can do this in Github too? So one list but included in any workflow.

martygrant avatar Apr 11 '24 13:04 martygrant

CI is now part of intel/llvm

kbenzie avatar Apr 08 '25 12:04 kbenzie