[Spec Constants] Improved handling of invalid spec. constants
Two main changes to how Kernel/ProgramSetSpecializationConstants are handled:
- They may now output either
INVALID_VALUEor the newINVALID_SPEC_IDwhen the provided list is invalid. - The OpenCL and level 0 adapters now respond to
UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTSwithfalserather than erroring out. This fixes some tests that were incorrectly not being skipped. urKernelSetSpecializationConstantsnow "implemented" (as a function that returnsUNSUPPORTED_FEATUREfor opencl and cuda.
Codecov Report
Attention: Patch coverage is 0% with 29 lines in your changes are missing coverage. Please review.
Project coverage is 12.42%. Comparing base (
78ef1ca) to head (7bb6c27). Report is 199 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## main #1469 +/- ##
==========================================
- Coverage 14.82% 12.42% -2.41%
==========================================
Files 250 241 -9
Lines 36220 36271 +51
Branches 4094 4111 +17
==========================================
- Hits 5369 4506 -863
- Misses 30800 31761 +961
+ Partials 51 4 -47
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@jchlanda is our spec constants expert. Jakub, please take over this review
could you fix the conflicts @RossBrunton ?
@RossBrunton I think the HIP match files need updated on this.
@RossBrunton I think the HIP match files need updated on this.
Forgot you were off. I would make the changes to this PR myself but the checkbox to allow project maintainers to make changes appears to have been disabled.
Can someone from @oneapi-src/unified-runtime-level-zero-write have a quick look at this? The changes for level_zero are reporting that it doesn't support UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS (which it doesn't yet).
@RossBrunton Please rebase this when possible, I removed the ready to merge label and please readd it when rebased.
@RossBrunton Please rebase this when possible, I removed the ready to merge label and please readd it when rebased.
Updated. Sorry for the delay.
EDIT: Never mind...
EDIT 2: And it's green again and should be ready to merge.