unified-runtime icon indicating copy to clipboard operation
unified-runtime copied to clipboard

Tighten spec for extension queries

Open aarongreig opened this issue 1 year ago • 3 comments

UR_DEVICE_INFO_EXTENSIONS and UR_PLATFORM_INFO_EXTENSIONS both return strings denoting "extensions supported" by the underlying adapter. The current implementations can return some pretty weird stuff, like cuda reporting support for a couple of OpenCL extensions, and a PI extension the line below that. In fact, OpenCL extension strings are reported by all the adapters. I suspect this behaviour is relied on by some element of the sycl RT but it isn't a good mechanism for communicating what it's trying to communicate, and we should definitely aim to get rid of it.

Beyond that a conversation needs to be had about what these queries are for. We deliberately avoided calling the various experimental features extensions, although we are now seeing some of them appear in the output of these queries. If we want them to be a mechanism for reporting support for UR experimental features then the spec should reflect that. If we want them to return extensions supported by the underlying API (i.e. have the CL adapter continue reporting CL extension strings) then that should explicitly be in the spec as well. I question the usefulness of both of these. Unless there's a compelling use case for returning native extension strings (which you could still do if you really wanted, by getting the native handle out), or reporting experimental feature support via a string rather than a ur_device_info_t enum like we mostly already do, we should consider these queries vestigial and remove them.

aarongreig avatar Feb 22 '24 10:02 aarongreig

I used the extension string for extension testing: https://github.com/oneapi-src/unified-runtime/pull/1369 Following command_buffer extension precedent.

JackAKirk avatar Feb 23 '24 09:02 JackAKirk

yeah that's partially what prompted this issue, I'm not going to argue against its use there since there's an established precedent

aarongreig avatar Feb 23 '24 10:02 aarongreig

Discussed 2024-02-28, removing OpenCL extension string here makes sense, but should check that this won't affect current SYCL-RT code.

alycm avatar Feb 28 '24 15:02 alycm