unified-runtime icon indicating copy to clipboard operation
unified-runtime copied to clipboard

[OPENCL] Add UR handles to OPENCL adapter

Open omarahmed1111 opened this issue 2 years ago • 2 comments

Redesign Opencl adapter by adding UR handles and get rid of the casting of the UR handles to OPENCL handles.

Intel/llvm testing

omarahmed1111 avatar Dec 11 '23 13:12 omarahmed1111

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 12.43%. Comparing base (78ef1ca) to head (97dbfd0). Report is 199 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1176      +/-   ##
==========================================
- Coverage   14.82%   12.43%   -2.40%     
==========================================
  Files         250      241       -9     
  Lines       36220    36242      +22     
  Branches     4094     4111      +17     
==========================================
- Hits         5369     4506     -863     
- Misses      30800    31732     +932     
+ Partials       51        4      -47     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 11 '23 14:12 codecov-commenter

I've not reviewed the whole PR yet. I think we need to run the CTS with the Address Sanitizer enabled to make sure we're not introducing memory leaks.

Used Address sanitizer to check for memory leaks, fixed some in the UR layer here. Some are generated from OpenCL sources so left that, others are generated from UR CTS tests that will be fixed in this PR

omarahmed1111 avatar Jan 23 '24 11:01 omarahmed1111

Currently taking over this to try to get it merged. I've just rebased it and created an LLVM change.

RossBrunton avatar Jan 29 '25 14:01 RossBrunton

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, all future development will now be carried out there. This was done in https://github.com/intel/llvm/pull/17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide has been updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days. To allow for some breathing space, this automation will not be enabled until next week (27/02/2025).

Should you wish to continue with your PR you will need to migrate it to intel/llvm. We have provided a script to help automate this process.


This is an automated comment.

martygrant avatar Feb 20 '25 11:02 martygrant

Unified Runtime -> intel/llvm Repo Move Notice

Following on from the previous notice, we have now enabled workflows to automatically label and close PRs because the Unified Runtime source code has moved to intel/llvm.

This PR has now been marked with the auto-close label and will be automatically closed after 30 days.

Please review the previous notice for more information, including assistance with migrating your PR to intel/llvm.

Should there be a reason for this PR to remain open, manually remove the auto-close label.


This is an automated comment.

martygrant avatar Feb 28 '25 10:02 martygrant

This change is now here: https://github.com/intel/llvm/pull/17118/commits/87fe1179c269a044d13b748c5a28a3916167bb5f

I'll recreate an MR in intel/llvm once prerequisites are merged.

RossBrunton avatar Feb 28 '25 11:02 RossBrunton