unified-runtime icon indicating copy to clipboard operation
unified-runtime copied to clipboard

Update and extend dockers

Open lukaszstolarczuk opened this issue 2 years ago • 6 comments

Add new docker images and update the existing ones with proper dependencies. I've made the installation of pip requirements part of the docker building, hence updated README with proper usage.

These images should be ready to use in CI.

// I've tested these dockers on a sep. branch (test-dockers) on my fork, results are all green: https://github.com/lukaszstolarczuk/unified-runtime/actions/runs/7846024815

lukaszstolarczuk avatar Nov 30 '23 12:11 lukaszstolarczuk

I have updated the target branch of this PR from the adapters branch to the main branch. Development in UR is moving back to main. The adapters branch will soon be deleted.

fabiomestre avatar Dec 05 '23 16:12 fabiomestre

Please add Hadolint support.

wlemkows avatar Jan 09 '24 17:01 wlemkows

Please add Hadolint support.

Done in #1253

lukaszstolarczuk avatar Jan 17 '24 15:01 lukaszstolarczuk

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (47102cb) 15.33% compared to head (d4d583f) 15.33%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
- Coverage   15.33%   15.33%   -0.01%     
==========================================
  Files         241      241              
  Lines       34820    34820              
  Branches     3989     3989              
==========================================
- Hits         5340     5339       -1     
- Misses      29429    29430       +1     
  Partials       51       51              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 22 '24 11:01 codecov-commenter

All Hadolint issues are resolved, except for apt/dnf/zypper pinned dependencies (which is ignored in the workflow). It's a topic to discuss if we want to pin versions instead of using the latest ones available in a distro.

The same applies to Scorecard, but the issue is not ignored 😉

lukaszstolarczuk avatar Jan 30 '24 13:01 lukaszstolarczuk

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

I've prepared the final version of this docker changes. Trivy was merged separately.

lukaszstolarczuk avatar Jul 24 '24 09:07 lukaszstolarczuk