unified-runtime icon indicating copy to clipboard operation
unified-runtime copied to clipboard

Remove ur_base_desc_t, use ur_base_properties_t instead.

Open aarongreig opened this issue 2 years ago • 3 comments

The definitions of these two base structs are slightly different which potentially has weird consequences if a given pNext chain contains extension structs derived from both. Unifying these structs removes the possibility of their definitions drifting further apart and prevents the mixed pNext chain scenario.

aarongreig avatar Nov 28 '23 16:11 aarongreig

@jandres742 it looks like UR inherited this design from level zero, do you have any insight on why two base structs were used, and if there's a good reason to keep them for UR?

aarongreig avatar Nov 29 '23 16:11 aarongreig

@jandres742 it looks like UR inherited this design from level zero, do you have any insight on why two base structs were used, and if there's a good reason to keep them for UR?

@aarongreig : I dont recall exactly, but I think original idea is that base_desc and base_properties could have other base fields added in the future, specific to descriptors and properties, besides pNext and stype. but as you mention.

I think change is good and would reduce code cluttering.

jandres742 avatar Nov 29 '23 17:11 jandres742

I have updated the target branch of this PR from the adapters branch to the main branch. Development in UR is moving back to main. The adapters branch will soon be deleted.

fabiomestre avatar Dec 05 '23 16:12 fabiomestre

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, all future development will now be carried out there. This was done in https://github.com/intel/llvm/pull/17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide has been updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days. To allow for some breathing space, this automation will not be enabled until next week (27/02/2025).

Should you wish to continue with your PR you will need to migrate it to intel/llvm. We have provided a script to help automate this process.


This is an automated comment.

martygrant avatar Feb 20 '25 11:02 martygrant

Unified Runtime -> intel/llvm Repo Move Notice

Following on from the previous notice, we have now enabled workflows to automatically label and close PRs because the Unified Runtime source code has moved to intel/llvm.

This PR has now been marked with the auto-close label and will be automatically closed after 30 days.

Please review the previous notice for more information, including assistance with migrating your PR to intel/llvm.

Should there be a reason for this PR to remain open, manually remove the auto-close label.


This is an automated comment.

martygrant avatar Feb 28 '25 10:02 martygrant

Automatic PR Closure Notice

Information

This PR has been closed automatically. It was marked with the auto-close label 30 days ago as part of the Unified Runtime source code migration to the intel/llvm repository - https://github.com/intel/llvm/pull/17043.

All Unified Runtime development should be done in intel/llvm, details can be found in the updated contribution guide. This repository will continue to exist as a mirror and will host the specification documentation.

Next Steps

Should you wish to re-open this PR it must be moved to intel/llvm. We have provided a script to help automate this process, otherwise no actions are required.


This is an automated comment.

github-actions[bot] avatar Mar 31 '25 00:03 github-actions[bot]