unified-runtime icon indicating copy to clipboard operation
unified-runtime copied to clipboard

Clarify spec for QUEUE_INFO_SIZE and change testing for it accordingly.

Open aarongreig opened this issue 2 years ago • 3 comments

LLVM testing https://github.com/intel/llvm/pull/12269

aarongreig avatar Nov 27 '23 16:11 aarongreig

I have updated the target branch of this PR from the adapters branch to the main branch. Development in UR is moving back to main. The adapters branch will soon be deleted.

fabiomestre avatar Dec 05 '23 16:12 fabiomestre

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (f15234d) 14.83% compared to head (f724434) 12.71%. Report is 7 commits behind head on main.

Files Patch % Lines
test/conformance/queue/urQueueGetInfo.cpp 0.00% 27 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
- Coverage   14.83%   12.71%   -2.12%     
==========================================
  Files         250      238      -12     
  Lines       36232    35364     -868     
  Branches     4097     4014      -83     
==========================================
- Hits         5376     4498     -878     
- Misses      30805    30862      +57     
+ Partials       51        4      -47     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 28 '23 15:12 codecov-commenter

ping @oneapi-src/unified-runtime-opencl-write @oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-hip-write

aarongreig avatar Feb 12 '24 12:02 aarongreig

@GeorgeWeb would be great if you could give this a review, seems like this predates the automatic reviewer team assignment being enabled.

kbenzie avatar May 30 '24 11:05 kbenzie