unified-memory-framework icon indicating copy to clipboard operation
unified-memory-framework copied to clipboard

WIP: pool memory resource that can be used with an upstream memory resource

Open igchor opened this issue 2 years ago • 4 comments

igchor avatar Dec 05 '23 21:12 igchor

Some general question: On the last WG meeting we agreed that we do not need to implement memory resources on top of UMF (at least not now), correct? Instead we are discussing to have memory resource implementation on top of SYCL. So why do we need this PR? Why not to focus on the items we agreed to implement for the next release?

vinser52 avatar Dec 05 '23 21:12 vinser52

@vinser52 that's correct, I just want to have something I can use for benchmarking/testing once we have the SYCL provider and different pool implementations (jemalloc). This PR just exposes some simple abstractions to build a pool memory_resource. I don't plan to have it merged for now. Would you prefer if I just kept it on a separate branch and not have the PR open?

igchor avatar Dec 05 '23 23:12 igchor

Thank you for your clarifications.

Would you prefer if I just kept it on a separate branch and not have the PR open?

Keeping it in a separate fork is OK. Regarding the branch instead of the fork do you mean creating a separate branch in this repo? Regarding PR, what is your intention by opening the PR? If you need a review than it totally makes sense and we can keep this PR and review/discuss the code.

vinser52 avatar Dec 06 '23 11:12 vinser52

My intention was just to have this visible so I can reference this PR when discussing the SYCL provider, show some examples, etc.

igchor avatar Dec 06 '23 18:12 igchor

outdated

bratpiorka avatar Sep 26 '24 12:09 bratpiorka