Implement missing functions on windows
Missing functions on windows should be implemented, and just return not supported return code. Currently, we just do not export some linux only functions on windows.
Which API do you mean? Do we have a list?
I think we should only ifdef things that will never work on Windows or use nix-specific things (like file descriptors). Things that are currently unimplemented (but will be eventually) should just fail at runtime.
I think we should only ifdef things that will never work on Windows or use nix-specific things (like file descriptors). Things that are currently unimplemented (but will be eventually) should just fail at runtime.
This is also an option. ATM we just do not provide symbol which is just bad
Which API do you mean? Do we have a list?
$ diff <(grep -o '\bumf\w*' libumf.def.in | sort) <(grep -o '\bumf\w*' libumf.map | sort)
7a7
> umfLevelZeroMemoryProviderOps
29a30
> umfMemspaceCreateFromNumaArray
30a32,35
> umfMemspaceHighestBandwidthGet
> umfMemspaceHighestCapacityGet
> umfMemspaceHostAllGet
> umfMemspaceLowestLatencyGet
since this is about .def and .map files - isn't this related to/duplicate of https://github.com/oneapi-src/unified-memory-framework/issues/566 ?
since this is about
.defand.mapfiles - isn't this related to/duplicate of #566 ?
No - this is only similar issue:
- those issue is about functions which was exported, but are not supposed to be exported. (internal function)
- this issue is about functions which are supposed to be exported but there are not
umfLevelZeroMemoryProviderOps
LevelZero provider should be supported on Windows.