unified-memory-framework icon indicating copy to clipboard operation
unified-memory-framework copied to clipboard

Add -Wsign-compare and -Wconversion flags

Open lplewa opened this issue 1 year ago • 1 comments

On windows some of those problems are detected - what causes fully working on Linux PR to fail on Windows, what is annoying. Unfortunately, those Flags are more restrictive then on windows (by adding those flags we have to fix ~40 warnings in the code)

Question: Do we want to include those compiler flags?

lplewa avatar Apr 15 '24 10:04 lplewa

I am for adding as many checks as possible :) at least if this costs us little effort. Fixing 40 easy warnings should be straightforward.

bratpiorka avatar Apr 15 '24 12:04 bratpiorka