oneTBB icon indicating copy to clipboard operation
oneTBB copied to clipboard

Extension of Nd range

Open tobiasweinzierl80 opened this issue 1 year ago • 1 comments

Description

We found that it is very useful for our code if we can construct the range from plain integers. For this, the underlying datatype storing the ranges has to be changed to vector. This should have no negative impact on the performance. However, it makes using the class easier.

The class could do with more assertions and more docu.

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • [ ] bug fix - change that fixes an issue
  • [X ] new feature - change that adds functionality
  • [ ] tests - change in tests
  • [ ] infrastructure - change in infrastructure and CI
  • [ X] documentation - documentation update

Tests

  • [ ] added - required for new features and some bug fixes
  • [ X] not needed

Documentation

  • [ X] updated in #555 of spec
  • [ ] needs to be updated
  • [ ] not needed

Breaks backward compatibility

  • [ ] Yes
  • [ X] No
  • [ ] Unknown

Notify the following users

List users with @ to send notifications

Other information

tobiasweinzierl80 avatar Jul 13 '24 16:07 tobiasweinzierl80

I have implemented the changes discussed in the spec as well as the changes concerning std::array. The initialization of the array in the constructor with parameter size[N] as described by @akukanov works from what I tested. As I said in the spec, I have removed the constructor that uses begin[N] and end[N] and renamed ndims to dim_count. Let me know if this poses a problem or if there is anything missing.

sasalla23 avatar Aug 28 '24 13:08 sasalla23