oneTBB icon indicating copy to clipboard operation
oneTBB copied to clipboard

Detect binutils version to disable waitpkg/tpause intrinsic if GNU assembler is too old.

Open mcourteaux opened this issue 10 months ago • 2 comments

Fixes #859 #1023.

Type of change

  • [x] bug fix - change that fixes an issue
  • [ ] new feature - change that adds functionality
  • [ ] tests - change in tests
  • [x] infrastructure - change in infrastructure and CI
  • [ ] documentation - documentation update

Tests

  • [ ] added - required for new features and some bug fixes
  • [x] not needed

Documentation

  • [ ] updated in # - add PR number
  • [ ] needs to be updated
  • [x] not needed

Breaks backward compatibility

  • [ ] Yes
  • [x] No
  • [ ] Unknown

Notify the following users

@mcmillan03 @kboyarinov @markdewing @phprus @isaevil @HorizonLiang @bsergean @pavelkumbrasev

Other information

mcourteaux avatar Apr 16 '24 12:04 mcourteaux

@aepanchi Please look at the comments wording.

omalyshe avatar Apr 18 '24 10:04 omalyshe

@omalyshe I changed the code to be matching better the comments and be less confusing.

mcourteaux avatar Apr 18 '24 11:04 mcourteaux

I updated the PR with your feedback, @isaevil.

mcourteaux avatar May 03 '24 09:05 mcourteaux