oneMKL
oneMKL copied to clipboard
[rocBLAS] Fix issues with rocBLAS 4.0.0
Description
rocBLAS 4.0.0 removed support for the legacy BLAS inplace trmm, so calls to trmm cause a compilation error. The old functionality is provided by just duplicating the last two arguments of trmm (see also here).
To fix this, I am defining a macro ROCBLAS_NO_LEGACY_TRMM
depending on the rocBLAS version which is then used in an #ifdef
to decide which version of the function to call.
I also had to change slightly the way the path to librocblas.so
is constructed in FindrocBLAS.cmake
. I'm not sure if this is also related to the rocBLAS version or if this is a general issue on some systems, so I can also put that in a separated PR if you prefer.
Checklist
All Submissions
- [ ] Do all unit tests pass locally? Attach a log. I don't have an AMD gpu to test, I'm just assessing the state of compiling oneMKL with AdaptiveCpp to see if #307 needs any updates and can the maybe be merged.
- [x] Have you formatted the code using clang-format?