oneMKL icon indicating copy to clipboard operation
oneMKL copied to clipboard

Move `lapack_info_check` inside of `onemkl_cusolver_host_task`

Open JackAKirk opened this issue 3 years ago • 2 comments

Description

In some cases cuSolver operations can return a successful error code while failing. The previous implementation of this check is done via SYCL and requires the CPU to wait until the cuSolver function completes. This is not great for performance as it prevents the user for issuing more work to the queue until it has received a response from oneMKL.

This PR moves the check inside the host task.

@AidanBeltonS I've updated the cusolver_batch.cpp cases too, can you check it is OK?

JackAKirk avatar Oct 13 '22 15:10 JackAKirk

LGTM!

AidanBeltonS avatar Oct 14 '22 07:10 AidanBeltonS

@ericlars Could we get a review of this from someone? Thanks

JackAKirk avatar Oct 19 '22 09:10 JackAKirk