oneMKL icon indicating copy to clipboard operation
oneMKL copied to clipboard

Published 20 hours ago • verified publisher icon oneapi-src

Adding Intel LLVM support for rocRAND backend

Open TejaX-Alaghari opened this issue 3 years ago • 1 comments

Description

This PR is intended to extend the HIP backend of RNG domain, which is currently supported for hipSYCL compiler to Intel’s LLVM compiler.

  • Added the build config for rocRAND and API launch with

All Submissions

  • [x] Have you formatted the code using clang-format?

New features

  • [x] Have you provided motivation for adding a new feature?

TejaX-Alaghari avatar Aug 01 '22 12:08 TejaX-Alaghari

@TejaX-Alaghari Thanks for the PR. Similar comments from #189 applies here as well. Can we first focus on #189 and then apply the similar updates to this PR as well?

mmeterel avatar Aug 10 '22 17:08 mmeterel

Looks good to me, are all issues in tests addressed? (there were some failures in the attached log)

The failures of these skip_ahead cases is a known issue in rocRAND and has been mentioned in this oneMKL PR (ref Note2).

TejaX-Alaghari avatar Oct 18 '22 00:10 TejaX-Alaghari

@vmalia @mkrainiuk Could you please review this PR and share your feedback as well.

TejaX-Alaghari avatar Oct 19 '22 05:10 TejaX-Alaghari

@aelizaro and @vmalia , following the recent commit to cuRAND backend, I've added support for handling kernel launch with hipSYCL and LLVM's host_task separately.

Requesting for review and merging the PR.

TejaX-Alaghari avatar Nov 01 '22 00:11 TejaX-Alaghari

@aelizaro and @vmalia, thanks for all the suggestions and reviews. @mkrainiuk, requesting for review.

TejaX-Alaghari avatar Nov 01 '22 01:11 TejaX-Alaghari