oneDPL icon indicating copy to clipboard operation
oneDPL copied to clipboard

[oneDPL] Fix include guard names in header files

Open SergeyKopienko opened this issue 2 years ago • 2 comments

Normalized include guard names in header files:

  • in file https://github.com/oneapi-src/oneDPL/blob/dev/skopienko/fix_include_guard_names_in_oneapi_dpl_headers/.clang-format we have next line: BasedOnStyle: LLVM
  • This line mean that we should create header file guards as described in Header Guard(https://llvm.org/docs/CodingStandards.html#header-guard) The header file’s guard should be the all-caps path that a user of this header would #include, using ‘’ instead of path separator and extension marker. For example, the header file llvm/include/llvm/Analysis/Utils/Local.h would be #include-ed as #include "llvm/Analysis/Utils/Local.h", so its guard is LLVM_ANALYSIS_UTILS_LOCAL_H._

SergeyKopienko avatar Oct 10 '22 12:10 SergeyKopienko

@rarutyun please make review too

SergeyKopienko avatar Oct 14 '22 07:10 SergeyKopienko

@rarutyun please make review too

SergeyKopienko avatar Oct 14 '22 08:10 SergeyKopienko

@rarutyun could you please take a look at this PR ?

SergeyKopienko avatar Oct 17 '22 12:10 SergeyKopienko