oneDPL icon indicating copy to clipboard operation
oneDPL copied to clipboard

Eliminate code duplication when increasing workgroup size

Open KseniiaBakina opened this issue 3 years ago • 2 comments

KseniiaBakina avatar Oct 27 '21 09:10 KseniiaBakina

A good practice is to describe the purpose of a patch - what problem(s) it intends to solve, etc. This patch has no description at all.

Also I am always suspicious of "refactoring" patches that increase the line count. LOC is the simplest yet often relevant metric of code complexity. This patch makes one file 19 lines shorter and another file 66 lines longer; that does not at all seem a useful refactoring.

akukanov avatar Nov 29 '21 18:11 akukanov

A good practice is to describe the purpose of a patch - what problem(s) it intends to solve, etc. This patch has no description at all.

Also I am always suspicious of "refactoring" patches that increase the line count. LOC is the simplest yet often relevant metric of code complexity. This patch makes one file 19 lines shorter and another file 66 lines longer; that does not at all seem a useful refactoring.

The pool request is not ready yet. The purpose of the pull request is to minify the code in the parallel_backend_sycl.h file functions. It will be convenient to look at the functions and understand what the code does after the code reduction.

KseniiaBakina avatar Dec 02 '21 09:12 KseniiaBakina

Closing this PR due to its controversial impact on the code readability.

dmitriy-sobolev avatar Dec 11 '22 18:12 dmitriy-sobolev