oneDPL icon indicating copy to clipboard operation
oneDPL copied to clipboard

Remove extra defines from `test/support/test_config.h` file

Open SergeyKopienko opened this issue 9 months ago • 1 comments

In this PR we remove extra defines from test/support/test_config.h which mark broken test cases in the tests of std::complex.

Motivation described here: https://github.com/oneapi-src/oneDPL/pull/1566#discussion_r1592663793

SergeyKopienko avatar May 08 '24 08:05 SergeyKopienko

I know this is now a draft, but I just want to preserve the state of my review: I've checked that the removed macros are properly replaced with their new consolidated replacement.

We will need to follow up on the following tests to see if we have added any new failures which need to be addressed by fixing the #ifndef bug which reenables some unintentionally skipped assertions.

Affected tests: acosh.pass asin.pass atan.pass cosh.pass pow_complex_complex.pass pow_complex_scalar.pass pow_scalar_complex.pass sin.pass norm1.pass polar.pass

danhoeflinger avatar May 08 '24 13:05 danhoeflinger