oneDPL icon indicating copy to clipboard operation
oneDPL copied to clipboard

[KT][ESIMD Sort] Code quality improvements

Open dmitriy-sobolev opened this issue 1 year ago • 0 comments

These are the gaps which remain after the main review (#1257):

  1. Separate declaration and definition (can be postponed until productization): See discussion: https://github.com/oneapi-src/oneDPL/pull/1257#discussion_r1407746163.
  2. Use zip_iterator/zip_view instead of __rng_pack: See discusison: https://github.com/oneapi-src/oneDPL/pull/1257#discussion_r1407747819 and https://github.com/oneapi-src/oneDPL/pull/1257#discussion_r1407876412.
  3. Consolidate trivial checks for the sequence length (see the checks like if (__keys_last - __keys_first < 2)).
  4. Refactor __onesweep_memory_holder class. See discussion: https://github.com/oneapi-src/oneDPL/pull/1257#discussion_r1409124463.
  5. Consider renaming __vector_store overloads to denote that they work with SLM. See discussion: https://github.com/oneapi-src/oneDPL/pull/1257#discussion_r1415838864.
  6. Get rid of loops in __one_wg_kernel and use native functions or helper wrappers where possible. Avoid bitcasts to uint32_t. See discussion: https://github.com/oneapi-src/oneDPL/pull/1257#discussion_r1415678866
  7. Make _ONEDPL_ESIMD_INLINE a genera macro to enforce inlining or replace it if there is an existing one. See discussion: https://github.com/oneapi-src/oneDPL/pull/1257#discussion_r1420753706

dmitriy-sobolev avatar Dec 11 '23 18:12 dmitriy-sobolev