oneDNN icon indicating copy to clipboard operation
oneDNN copied to clipboard

eigen: Fix Eigen version comparison.

Open cantonios opened this issue 3 months ago • 3 comments

Description

The existing Eigen threadpool test uses an incorrect version comparison, which breaks with any new development branch or released version Eigen. Setting the dependency to anything newer than 3.3.7 that is not a 3.x development branch will trigger a build error. For example, with the recently released Eigen 5.0.0.

This change corrects the version comparison for the switch from Eigen::NonBlockingThreadPool to Eigen::ThreadPool, which happened with release 3.3.8.

Checklist

General

  • [X] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • [X] Have you formatted the code using clang-format?

Bug fixes

  • [X] Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
  • [N/A] Have you added relevant regression tests?

cantonios avatar Oct 10 '25 21:10 cantonios

@dzarukin fixing an Eigen issue encountered internally at Google

cantonios avatar Oct 10 '25 21:10 cantonios

Hi @cantonios, thanks for taking care about it. I have a PR opened where I completely got rid of it: https://github.com/uxlfoundation/oneDNN/pull/4087 and switch to ThreadPool object instead for synchronous implementation (coming from Tensor header). We plan to move to v5.0.0 and set it as a minimal version, hope it's aligned with your plans.

dzarukin avatar Oct 10 '25 22:10 dzarukin

Hi @cantonios, thanks for taking care about it. I have a PR opened where I completely got rid of it: #4087 and switch to ThreadPool object instead for synchronous implementation (coming from Tensor header). We plan to move to v5.0.0 and set it as a minimal version, hope it's aligned with your plans.

Okay, great.

cantonios avatar Oct 10 '25 23:10 cantonios