oneDNN icon indicating copy to clipboard operation
oneDNN copied to clipboard

[CPU] [RISC-V] add compatible headers for new version of rvv intrinsics

Open BHbean opened this issue 1 year ago • 2 comments

Description

I have been trying to cross-compile openvino for RISC-V target with rv64gcv arch recently, and I found an issue related to compatiblity of rvv intrinsics. See this issue for detailed information.

Fixes the following github issue https://github.com/openvinotoolkit/openvino/issues/23784

Checklist

General

  • [x] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • [x] Have you formatted the code using clang-format?

Performance improvements

  • [ ] Have you submitted performance data that demonstrates performance improvements?

New features

  • [ ] Have you published an RFC for the new feature?
  • [ ] Was the RFC approved?
  • [ ] Have you added relevant tests?

Bug fixes

  • [x] Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
  • [ ] Have you added relevant regression tests?

RFC PR

  • [ ] Does RFC document follow the template?
  • [ ] Have you added a link to the rendered document?

BHbean avatar Apr 02 '24 15:04 BHbean

The fact that this patch includes 30K LOCs of copy pasted code is a bit intimidating. I would suggest updating intrinsics in pooling implementation to RVV intrinsics v0.11 or even better stable RVV intrinsics v0.12. Compiler support is documented here.

vpirogov avatar Apr 18 '24 16:04 vpirogov

The fact that this patch includes 30K LOCs of copy pasted code is a bit intimidating. I would suggest updating intrinsics in pooling implementation to RVV intrinsics v0.11 or even better stable RVV intrinsics v0.12. Compiler support is documented here.

Thanks for your reply! I will try to update the intrinsics to the latest stable version! :)

BHbean avatar Apr 20 '24 04:04 BHbean