astro-ink
astro-ink copied to clipboard
one-aalam
fix: updates dark theme syntax for Astro + Tailwind support
This replaces all remaining uses of @apply dark:___ with inline class names
It looks like the class names get lost somewhere along the build and Tailwind never recognizes that the dark: class was used, I'm guessing our compiler may sanitize it to dark/:?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| astro-ink | ✅ Ready (Inspect) | Visit Preview | Dec 6, 2022 at 10:45PM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for astro-ink ready!
| Name | Link |
|---|---|
| Latest commit | 751c1d1aa39e4c4390653373ac81c97bdfdfa2f1 |
| Latest deploy log | https://app.netlify.com/sites/astro-ink/deploys/638fc5cc1f83d900080309d9 |
| Deploy Preview | https://deploy-preview-28--astro-ink.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi, @tony-sull Thank you for the PR. Let me get back on this.
I'd prefer to keep the current CSS class structure if possible
No problem at all! I kept this one separate from the dependency updates, thought this change might not be wanted 😅
I couldn't find another way to get dark mode to work consistently between Astro's styles and Tailwind dark mode classes, maybe there's a better way though. Happy to close this PR if you'd prefer to keep it as-is