wwwsqldesigner
wwwsqldesigner copied to clipboard
ondras
New layout, added Material design, and shortcuts
Following #252 impulse i submit thee
Changes appearing in diff for following directories were made when i merged upstream, i did not modify them:
- backend
- db
- locale
Features
- Zoom In & Out
- Shortcuts
- Improved UI/UX (i hope)
Changes
- Mainly edited index.html and style.css for layout
- And .js files like row, rowmanager, wwwsqldesigner
- some .js appear modified but are only because Netbeans uses a different code format (sorry for that)
Hope you like it :smile:
Wow, this looks huge :+1:
I am extremely busy these days, so please give me some time so I can thoroughly review this PR and decide whether this redesign is consistent with my intentions of maintaining the app. If I do not reply within say 1-2 weeks, feel free to ping me again ;-)
@ondras I'm taking the liberty of pinging you again :) This one looks nice.
Thanks!
I am now on a vacation. Will be returning back to civilization at 27.8., so after that I will try to find some time to merge this.
Can we have this as a selectable style? I think I prefer the simplicity of the original UI
Can we have this as a selectable style? I think I prefer the simplicity of the original UI
This sounds like a very reasonable request. Ideally, the styling should happen via CSS switching (only).
So, I just skimmed through the diff. It is huge and we will have to split the changeset in order to merge it meaningfully.
I suggest doing this in the following manner:
-
applying only those changes that are related to your editor, i.e. newlines, indents etc. This commit will not modify the app at all.
-
applying changes that are related to behavior, i.e. keyboard controls (are there any other interaction modifications?).
-
applying changes that are related to styling. Ideally, this should happen exclusively via CSS. If the underlying HTML needs to be adjusted, I would like to have to current CSS updated as well, so that the material design can be kept around as a skin, self-contained using a separate stylesheet (and images).
The first point might be doable simply by opening the current codebase in your editor, re-saving (re-formatting) every file and commiting into a new branch. If this works, you can then merge this re-formatted branch into your redesign, reducing the size of your current PR.
Hey, sorry i couldn't answer sooner.
Soo, i didn't really code this re-design with "polite" merging in mind (or merging for that matter) :/ so i don't know if points 2 and 3 will be that straightforward. Let me see if i can get some time in my hands to think about it, and also do it :smile:
About the formatting, if i roll back to your formatting, wouldn't that be easier? am i missing a reason why not to?
hello no news from this PR ?
Yeah, no news, unfortunately. The PR is simply too large and destructive with respect to current codebase, so merging it seems to be a one-way transition with no means of going back (for example: people who, for some reason, might prefer the old way).
If you absolutely need the functionality/design provided in the PR, feel free to fork this project and apply relevant changesets to your repo.
No need "absolutely" but a new look and feel (but with backward compatibility) is a good think :)
