my-mind icon indicating copy to clipboard operation
my-mind copied to clipboard

disabled save button

Open Light13008 opened this issue 2 years ago • 2 comments

disabled save button under Generiv WebDAV, changed the input type to 'url' and checked the button only after filling the input field.

Light13008 avatar Oct 04 '23 23:10 Light13008

Hi @Light13008 ,

thanks for your contribution. Unfortunately, this is not sufficient. The my-mind.js file is automatically generated during the build process, so your code will get overwritten every time the app is built.

You need to add your code somewhere inside the real source code (the src/ subdirectory) and re-build the project yourself (via make). Ideally to https://github.com/ondras/my-mind/blob/master/src/ui/backend/webdav.ts - this module corresponds to the WebDAV UI.

Furthermore:

  • do not add the id attribute (dangerous! there may be more URL-related inputs in the app); instead, use the this.url property of the WebDAVUI class
  • to retrieve the button, try this.go
  • instead of doing removeAttribute/setAttribute, just set button.disabled

ondras avatar Oct 05 '23 06:10 ondras

Thanks for your insights, I will surely get the changes done soon.

Light13008 avatar Oct 05 '23 06:10 Light13008