browsershot icon indicating copy to clipboard operation
browsershot copied to clipboard

Published 20 hours ago • verified publisher icon ondras

Better screenshot

Open ilblog opened this issue 5 years ago • 2 comments

helps to make a shot not so shitty

ilblog avatar Apr 16 '19 08:04 ilblog

Thanks for the PR!

The resizeMode makes complete sense. I am not that sure about sharpness -- we probably want to have the image 100% similar to the original rendering. Supplying custom sharpness value might, in theory, result in applying an edge-detection operator (https://w3c.github.io/mediacapture-image/#sharpness), effectively creating a different (over-sharpened) image.

Is there any implementation of the sharpness option available for reference?

ondras avatar Apr 16 '19 08:04 ondras

Some rudimentary observations:

  • Firefox (66.0.3, Linux) does 1:1 perfect shots
  • Chrome (73.0.3683, Linux) does blurry shots, even with both options specified. The resulting canvas height is one pixel less than the window height, so probably some resampling is taking place.

ondras avatar Apr 16 '19 10:04 ondras