dynamodb-simple icon indicating copy to clipboard operation
dynamodb-simple copied to clipboard

Update amazonka

Open MichaelXavier opened this issue 2 years ago • 2 comments

This MR updates the repo to be compatible with the current develop branch of amazonka. Amazonka has not been getting releases to hackage with any kind of regularity so at my job we've moved to tracking the develop branch. Because your project is released to hackage you might decide that you only want to target the hackage 1.6.1 version which was released in February 2019, in which case feel free to close this MR or keep it open until amazonka gets a release.

There's a lot of diff here but here's a summary of the changes to amazonka off the top of my head:

  • amazonka-core is gone
  • MonadAWS/RunAWS are gone. Instead, send takes the env value directly. So your APIs that hit AWS now take an additional argument.
  • All constructors are prefixed with new, e.g. putItem becomes newPutItem
  • All field lenses now live in a dedicated lens module and are prefixed with the full type (e.g. putItem_) instead of a cryptic abbreviation.
  • Most sum types are now actually a newtype over Text and what were previously sum type constructors are view patterns. I had to add a custom sum type ScalarValueType for the GADT ScalarValue because you can't use view patterns as type parameters for GADTs. The functionality should be equivalent though.
  • Most fields in requests/response that are of type [a] are now Maybe [a]. So you'll see a lot of fromMaybe mempty that smooths over this.

I also added stack files to make it a bit easier to test reproducibly but feel free to remove that.

I've merged this branch into a large project that uses dynamodb-simple and so far everything seems to be working.

MichaelXavier avatar Sep 21 '21 15:09 MichaelXavier

Wow. I don't follow the dev cycle of amazonka, but I have a few projects that use that; that's going to be fun :( I think I'd probably keep it open, until amazonka is released on hackage. Could you ping me when this happens?

To be honest, I don't use this library anymore, I switched the app to sql.. any interest into becoming a maintainer? :)

ondrap avatar Sep 30 '21 10:09 ondrap

I don't think I can in good conscience agree to becoming sole maintainer, but since my work uses this library I'd be okay with being a co-maintainer. Seems like there isn't much issue volume with the library, so that's good!

MichaelXavier avatar Oct 12 '21 17:10 MichaelXavier