csob icon indicating copy to clipboard operation
csob copied to clipboard

Keys as file path - why?

Open jspetrak opened this issue 1 year ago • 2 comments

Hello, Is there a reason why the keys must be provided as file paths? We are obtaining the keys from AWS S3 so I now workaround using tmp file but would like to provide a PR to be able to provide the key values directly.

jspetrak avatar Apr 06 '23 14:04 jspetrak

Hi, I think there is no reason for that, it was just the most common way how the key was saved. If you make a PR that enables both ways to provide the key, that will be great.

ondrakoupil avatar Apr 07 '23 09:04 ondrakoupil

@ondrakoupil Thanks for the reaction. I have proposed the change in pr #54. Feel free to comment if you like that or prefer different approach. It is also a BC, but that could be resolved by the union type string|KeyProvider.

jspetrak avatar Apr 11 '23 17:04 jspetrak