Önder Kalacı comments

Results 84 comments of


                                            Önder Kalacı

Flaky columnar regression test

happened again

Allow Citus local tables with 2PC

I'll think a little more

Citus may have lead to PANIC in Abort[Sub]Transaction - Investigate a Abort[Sub]Transaction functions for possible bugs

Another relevant core-dump: ``` Program terminated with signal SIGSEGV, Segmentation fault. #0 0x0000000003d3a620 in ?? () (gdb) bt #0 0x0000000003d3a620 in ?? () #1 0x00007f285d634ee8 in plpgsql_subxact_cb (event=, mySubid=2, parentSubid=,...

Citus may have lead to PANIC in Abort[Sub]Transaction - Investigate a Abort[Sub]Transaction functions for possible bugs

We saw this in one more cluster as well

Citus may have lead to PANIC in Abort[Sub]Transaction - Investigate a Abort[Sub]Transaction functions for possible bugs

Open question: Do we need something like `CommitContext ` in subXact callbacks as well?

Create CodeQL workflow for static analysis

> our statical analysis tool, CodeQL. This sounds useful. If it doesn't add too much overhead to the CI, do you plan to merge?

Actually enable TLS/SSL for old clusters by default

> DESCRIPTION: Enable TLS by default for clusters created before Citus 8.1.0 Seems too old, I'm closing the PR. If you think otherwise, please re-open @JelteF

Improve test targets in Makefile

> @onurctirtir any plan on updating and merging this PR ? @onurctirtir this looks useful. Do you plan to apply the feedback and merge?

Warn we are not propagating GRANT/REVOKE to workers

This is not relevant as we now propagate GRANT/REVOKE commands via https://github.com/citusdata/citus/pull/6008

Create all foreign keys quickly at the end of a shard move

Is there anything interesting changing regarding https://github.com/citusdata/citus-enterprise/issues/284?