Bash-Oneliner
Bash-Oneliner copied to clipboard
onceupon
Itsf4llofstars: Removed double entry
Good day, thanks for the repository, and the wealth of Bash knowledge it holds. I saw the issue #37 on "When sound not working" and removed the second entry and left the the entry with the Alt-F2 note. I'm still new to contributing to non-practice repositories so any feedback is greatly appreciated. Thanks, cheers.
Sorry, I didn't see any guidance on needing the signed off by line in the commit until I got the checks failed message. I went back to my local repo and had to do a revert, make the change again, commit with the -s options. I pushed to my fork and thought I would wait until you said it was okay to open another PR, but it looks like GitHub put the -s commit I just did with my PR. At this point I'm not sure what I can do, please let me know, if you need to delete my Pr and have me do it again I'll be happy to do that, thanks. Sorry again. Cheers.
hi, sorry that it's too late for me to read your PR, thank you for trying to fix the issue for me. FYR, the sign off check is required by the platform, but i can choose to ignore it or simply set it to pass. You are welcome for more PRs!
