rename icon indicating copy to clipboard operation
rename copied to clipboard

Renaming BundleID also Renames BundleID of iOS Extensions.

Open 10ndavis opened this issue 1 year ago • 11 comments

I created an Extension for Awesome Notifications FCM and when using the rename package to set the BundleID of my Flutter app, it also modifies the BundleID of the extension.

Steps to repeat:

  • Create Flutter App
  • Add a new Extension via xcode
  • Run flutter pub global run rename --bundleId com.example.app -t ios

Results: All instances of PRODUCT_BUNDLE_IDENTIFIER in project.pbxproj are renamed, thus renaming all extensions in the process.

10ndavis avatar Jun 14 '23 14:06 10ndavis

Hey @10ndavis , currently package doesn't support the flavor or any extensions but we will consider to add it in the future but for now it is not available.

onatcipli avatar Sep 23 '23 23:09 onatcipli

@onatcipli that's fine, but that's not what i'm reporting. This is a bug, in that is is renaming extensions-- and should not.

10ndavis avatar Sep 24 '23 00:09 10ndavis

@10ndavis same problem, did you find any solution?

OlehMysak avatar Oct 01 '23 20:10 OlehMysak

hey @OlehMysak @10ndavis , Can you have try with the latest version and let me know please?

Usage changed a little bit I recommend to have look to readme before using it.

pub.dev/packages/rename

onatcipli avatar Oct 02 '23 06:10 onatcipli

@onatcipli Screenshot 2023-10-02 at 13 35 09 Screenshot 2023-10-02 at 13 35 39 Screenshot 2023-10-02 at 13 36 10 I updated to latest version, but have same issue

The bundleId changes not only in the runner, but also in OneSignalNotificationServiceExtension, and it should be like in the 3 photos, is it possible to somehow change it only in the runner, and for OneSignalNotificationServiceExtension (in my case) or register separately, or so that it changes only the main bundle, but that left .OneSignalNotificationServiceExtension

OlehMysak avatar Oct 02 '23 10:10 OlehMysak

I found alternative package working perfect and more correct.

https://github.com/OutdatedGuy/package_rename

quyenvsp avatar Nov 13 '23 10:11 quyenvsp

Hi @onatcipli have you check package_rename_plus?

chandrabezzo avatar Jan 02 '24 13:01 chandrabezzo

@chandrabezzo What's the difference between package_rename and (your) package_rename_plus?

songpola avatar May 01 '24 13:05 songpola

@songpola the different is about the key override_old_package on iOS. So, we can safely renamed the bundle identifier from your another target like NotificationService, PushTemplateExtension, and etc. Related to the issue that raised.

chandrabezzo avatar May 07 '24 09:05 chandrabezzo

@songpola the different is about the key override_old_package on iOS. So, we can safely renamed the bundle identifier from your another target like NotificationService, PushTemplateExtension, and etc. Related to the issue that raised.

Nice! This should be noted in your README too :)

songpola avatar May 07 '24 09:05 songpola