nasc-vscode-mac-touchbar icon indicating copy to clipboard operation
nasc-vscode-mac-touchbar copied to clipboard

Add more buttons

Open felipenmoura opened this issue 7 years ago • 25 comments

Once we got support for the user to customize the buttons (still depending on some fixes in the touchbar support for the vsCode), we could have some extra buttons:

  • [x] Rename file (already has an open PR)
  • [x] Duplicate selection/line
  • [x] Find next
  • [x] Select next
  • [x] Toggle "show white spaces"
  • [ ] Fold/unfold
  • [x] Toggle block comment
  • [x] Find all references
  • [x] Peek definitions
  • [x] snap tab left (internally to app - not OS)
  • [x] snap tab right (internally to app - not OS)
  • [x] toggleSuggestionDetail (control+spacebar)

Any other suggestion?

felipenmoura avatar Oct 31 '17 21:10 felipenmoura

  • find all references
  • peek definition
  • close all tabs
  • close others
  • snap tab left (internally to app - not OS)
  • snap tab right (internally to app - not OS)

daveshirman avatar Nov 02 '17 09:11 daveshirman

Trigger intellisense manually, useful for knowing CSS property has what values.

Right now the shortcut key is control+spacebar

omartan avatar Nov 05 '17 14:11 omartan

Just published an update adding quite a few extra tools. I hope you enjoy it.

Again, open for suggestions for features (or perhaps, better symbols to use as icons)

felipenmoura avatar Nov 06 '17 02:11 felipenmoura

Now, in the version 1.8+ we got the chance to GROUP buttons. This way, the user can enable the groups in the settings and have access to all the features. Please try it out and let me know if you face any problem :)

felipenmoura avatar Nov 07 '17 13:11 felipenmoura

Odd, I don't see the update in VSCode

omartan avatar Nov 07 '17 14:11 omartan

hm, odd it is! Even if you go to the list of installed extensions? There should be a button for you to look for updates there. When you look for the extension, do you see the updated readme file with a few extra screenshots?

felipenmoura avatar Nov 07 '17 18:11 felipenmoura

Is it easy enough to add these two options:

  • snap tab left (internally to app - not OS)
  • snap tab right (internally to app - not OS)

I use them all the time and the keyboard shortcuts either don't exist or are ridiculous!

daveshirman avatar Nov 13 '17 20:11 daveshirman

Sure, why not. But I'm not sure what are those! I thought those where "increase/decrease indentation". In the list here: https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts

Which one is what you are looking for?

felipenmoura avatar Nov 13 '17 22:11 felipenmoura

I don't know if there is a shortcut for it - it's when you drag a tab to the left or right and it fills half the window, like windows does with window snapping, but inside the app itself.

On Mon, Nov 13, 2017 at 10:06 PM, Felipe Nascimento de Moura < [email protected]> wrote:

Sure, why not. But I'm not sure what are those! I thought those where "increase/decrease indentation". In the list here: https://code.visualstudio.com/docs/getstarted/keybindings#_ when-clause-contexts

Which one is what you are looking for?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NascHQ/nasc-vscode-mac-touchbar/issues/2#issuecomment-344074974, or mute the thread https://github.com/notifications/unsubscribe-auth/ANnlXt-J_atQdiQZ8N9pObW_XQaSRjrsks5s2L2BgaJpZM4QNboq .

daveshirman avatar Nov 13 '17 22:11 daveshirman

hm, interesting. I think that is the "split editor", isn't it? I'm guessing these would be the options you are looking for! You want to make it happen and open a PR? If not, I might have time to implement it next weekend.

screen shot 2017-11-13 at 20 20 39

felipenmoura avatar Nov 13 '17 22:11 felipenmoura

Yep those look like the ones. Again, I have no time outside of my projects sorry, all yours! Loving your work :)

On Mon, Nov 13, 2017 at 10:22 PM, Felipe Nascimento de Moura < [email protected]> wrote:

hm, interesting. I think that is the "split editor", isn't it? I'm guessing these would be the options you are looking for! You want to make it happen and open a PR? If not, I might have time to implement it next weekend.

[image: screen shot 2017-11-13 at 20 20 39] https://user-images.githubusercontent.com/347387/32752405-31df1e14-c8b0-11e7-8247-79a94bca1bf9.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NascHQ/nasc-vscode-mac-touchbar/issues/2#issuecomment-344078975, or mute the thread https://github.com/notifications/unsubscribe-auth/ANnlXkI4z0LRZ6dD4jv1vZ6P_m5_wSjfks5s2MEjgaJpZM4QNboq .

daveshirman avatar Nov 13 '17 23:11 daveshirman

I would like to create buttons that just insert some text, e.g. "def". On a german keyboard I have to press option-5 for a [ which is not convenient, so I would also like to have a button for brackets etc.

OliverUrbann avatar Dec 01 '17 12:12 OliverUrbann

hm, interesting...we could think of a button that could add whatever you want, so you could configure it in the settings...would that help?

felipenmoura avatar Dec 01 '17 23:12 felipenmoura

Actually some hours later I've found BetterTouchTool which exactly provides this feature, sending arbitrary keystrokes with configurable button images. However, it is not context sensitive, so e.g. in my PyCharm setup I have always the debug buttons (step etc.) on the Touch Bar. Here my current setup:

touchbar

OliverUrbann avatar Dec 02 '17 11:12 OliverUrbann

Interesting @OliverUrbann and what plugin is that? We might get some inspiration from it (specially if it is open source).

felipenmoura avatar Dec 04 '17 02:12 felipenmoura

It's not open source and it is not a plugin. It is a general tool for customizing gestures, touch bar etc. in every app.

OliverUrbann avatar Dec 04 '17 09:12 OliverUrbann

I see. Ok, let's see if we can add this feature here, so developers will have their custom controls contextualized to VSCode.

felipenmoura avatar Dec 04 '17 19:12 felipenmoura

VSCode reload button( linters/git/jest freeze sometimes) would be nice to have

liqwid avatar Dec 21 '17 09:12 liqwid

"Change color theme" would be pretty neat 😄

alexkrolick avatar Mar 08 '18 00:03 alexkrolick

Run Selection (F8) would be really useful

bnygld avatar May 01 '18 12:05 bnygld

Interesting, you mean "run selected text in terminal"?

felipenmoura avatar May 07 '18 05:05 felipenmoura

Yes and no. Selfishly, I want Powershell.RunSelection but the command for other languages is workbench.action.terminal.runSelectedText I created a fork to try and add it myself but this is my first extension so it's a bit of trial & error at the moment. Watch this space!

bnygld avatar May 08 '18 10:05 bnygld

Organise imports and code auto formatting would also be useful

piyushgupta1 avatar Jul 13 '18 08:07 piyushgupta1

Yes and no. Selfishly, I want Powershell.RunSelection but the command for other languages is workbench.action.terminal.runSelectedText I created a fork to try and add it myself but this is my first extension so it's a bit of trial & error at the moment. Watch this space!

Did you get it working, @benny-gold ?

felipenmoura avatar Jun 19 '19 17:06 felipenmoura

+1 on find all references option, the key combo Option+Shift(+Fn)+F12 is kinda awkward.

robjtede avatar May 29 '20 12:05 robjtede