Curtis Vogt

Results 388 comments of Curtis Vogt

That seems like a good option. Something else that comes to mind is that the `brew update` call doesn't look strictly necessary. Maybe making the update optional works in this...

This reminds me of: ```julia help?> collect(::Type, ::Any) collect(element_type, collection) Return an Array with the given element type of all items in a collection or iterable. The result has the...

You are correct that TimeZones.jl only requires the `windowsZones.xml` file from the CLDR artifacts. This is an unfortunate side effect of this package switching to use Julia artifacts which requires...

The PR https://github.com/JuliaTime/TimeZones.jl/pull/439 changed the Unicode CLDR artifacts to no longer be non-lazy and platform specific. Although this doesn't impact the download size on Windows machines it does limit the...

Did some basic local testing but need to add real tests before this is ready for review

> And then, `convert` for Int128 is expensive, because it widens to a `BigInt` for some reason The only `widen` call during construction is from `max_exp10`. If you're performing math...

I'll try to re-review this week. I'll note the CI is failing on Julia 0.6.

That particular example you show is specifically talking about avoiding using `import` to add methods to functions defined by other packages. For usage of code using `import LinearAlgebra` is reasonable...

@austinvazquez could you review?

Ran into a similar error on CxxWrap 0.13.4: ```julia ERROR: MethodError: no method matching push_back(::CxxWrap.StdLib.StdVectorDereferenced{CxxWrap.StdLib.SharedPtr{ ray_core_worker_julia_jll.LocalMemoryBuffer}}, ::CxxWrap.CxxWrapCore.CxxRef{ray_core_worker_julia_jll.LocalMemory Buffer}) Closest candidates are: push_back(!Matched::Union{CxxWrap.StdLib.StdVector{Any}, CxxWrap.CxxWrapCore.CxxRef{