omnivore icon indicating copy to clipboard operation
omnivore copied to clipboard

🐛 BUG: Obsidian Omnivore plugin does not create notes

Open sschneider-ihre-pvs opened this issue 1 year ago • 7 comments

When I try to sync the tutorial articles I get

image

but nothing is created in obsidian. I have checked sync all articles. and i have an api key

sschneider-ihre-pvs avatar Jul 05 '23 12:07 sschneider-ihre-pvs

It seems that, if there has not been any changes, metadata or content they will not sync

sschneider-ihre-pvs avatar Jul 05 '23 12:07 sschneider-ihre-pvs

@sschneider-ihre-pvs do you mean you add a note to an article that has already been synced, and then attempt to re-sync and the note is not pulled in?

jacksonh avatar Jul 05 '23 16:07 jacksonh

more like, a brand new account where only the tutorials are there and I cannot sync that, or if I add an article with the browser extension without changing anything it also seems to be ignored, as soon as I touch something the obsidian plugin is able to pull them in.

sschneider-ihre-pvs avatar Jul 06 '23 08:07 sschneider-ihre-pvs

I tested this issue and noticed the same. When I looked into further in code, the issue reported is a result of the command behavior and default filter setting. There's no actual bug technically in Omnivore itself

Repro

The plugin's two commands:

  • Sync - sync any article with "changes" from "Last Sync" date (i.e. when you run the Sync command)
  • Resync - sync articles regardless "Last Sync" date (i.e. it clears the "Last Sync" date and runs Sync)

Filter: The condition to filter the result. The default is "import just Highlights"

Plugin Behavior: The articles returned is the result pulled by Sync (or Resync), filtered down by the Filter.

This is my following sequence (and likely what OP did):

  1. Run Sync (user wanting to pull all my articles)
  • Because it's a new account, nothing is highlighted, so no articles are returned
  1. Run Sync/Resync again, same thing as 1.
  2. Noticed the Filter in the setting, change to "import All my Articles"
  3. Run Sync again
  • ("Bug") Because the behavior of Sync, only articles with delta are being pulled in, despite the filter being changed.

If I do "Resync" after step 3 or 4, the plugin works correctly in pulling everything I need

aaachen avatar Dec 20 '23 19:12 aaachen

Admittedly this would seem like a bug for the User's UX without any code insight, maybe we can

  • Clarify the commands and settings a bit? (i.e. the Sync/Resync command, the last sync date setting, etc.)
  • Do a code change that if "Filter" is changed, we clear the last sync date? Personally I think this makes sense UX wise (i.e. we want a fresh sync with the latest filter)

aaachen avatar Dec 20 '23 19:12 aaachen

yeah, this is affecting more users and thanks guys for the clear description.

agree with @aaachen's both idea and i will work on them.

besides that, do you guys think we should default sync all items instead of just highlights? cc @jacksonh @sschneider-ihre-pvs

sywhb avatar Dec 21 '23 09:12 sywhb

Here's PR: https://github.com/omnivore-app/obsidian-omnivore/pull/168

@sywhb I can help take this if you haven't got a chance yet to work on

aaachen avatar Dec 21 '23 17:12 aaachen

Edit: The plugin settings are weird. Sometimes, changing settings fixes it, sometimes, it breaks it. I've gotten it to work for now, but I'm not touching my setting anymore.

I believe I am experiencing this same issues. I've synced, resynced, and nothing populated the Omnivore folder. All of my settings are default, including the filter, so the full article should be saved. I added a few highlights and notes and those did not move over either. I have removed the plugin, created a new API key, and reinstalled the plugin using my new API key, and same result. I am on iOS 17.3.

johnnynalley avatar Feb 05 '24 13:02 johnnynalley