omnivore icon indicating copy to clipboard operation
omnivore copied to clipboard

Links are not styled in Firefox

Open xplosionmind opened this issue 2 years ago • 9 comments

Discussed in https://github.com/omnivore-app/omnivore/discussions/1392

Originally posted by xplosionmind November 3, 2022 By reading an article inside Omnivore, links are disguised within the text since they do not have any different graphical styling.

The only way to find a link is to pass the cursor over all of the text until the pointer changes into indicating that the element under it is clickable.

While the reading experience can become less distracting, I believe users should be given the choice whether to uniform links styling with the text or to make them pop out: #1391.

As @Bad3r suggested, I tried saving articles by pasting the link and not via extension. The issue persists. I used this article, but this happens with any article. I use uBlock Origin, but this error occurs both if it is enabled or disabled.

This is what my console shows:

09:46:18.373 SingleFile is hooking the IntersectionObserver API to detect and load deferred images. single-file-hooks-frames.js:1:541
09:46:18.382 SingleFile is hooking the IntersectionObserver API to detect and load deferred images. single-file-hooks-frames.js:1:531
09:46:18.435 The resource at “https://platform.twitter.com/widgets.js” was blocked because content blocking is enabled. trunk-for-the-fediverse-18517fa2d7f
09:46:18.635 Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://vitals.vercel-insights.com/v1/vitals. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 200.
09:46:18.635 TypeError: NetworkError when attempting to fetch resource.
09:46:18.688 Some cookies are misusing the recommended “SameSite“ attribute 2
09:46:19.683 Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://vitals.vercel-insights.com/v1/vitals. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 200.
09:46:19.683 TypeError: NetworkError when attempting to fetch resource.
09:46:34.777 Navigated to https://omnivore.app/tommi/trunk-for-the-fediverse-18517fa2d7f
09:46:35.430 SingleFile is hooking the IntersectionObserver API to detect and load deferred images. single-file-hooks-frames.js:1:541
09:46:35.434 SingleFile is hooking the IntersectionObserver API to detect and load deferred images. single-file-hooks-frames.js:1:531
09:46:35.477 The resource at “https://platform.twitter.com/widgets.js” was blocked because content blocking is enabled. trunk-for-the-fediverse-18517fa2d7f
09:46:35.803 Some cookies are misusing the recommended “SameSite“ attribute 2
09:46:35.958 Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://vitals.vercel-insights.com/v1/vitals. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 200.
09:46:35.958 TypeError: NetworkError when attempting to fetch resource.
09:46:36.041 Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://vitals.vercel-insights.com/v1/vitals. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 200.
09:46:36.041 TypeError: NetworkError when attempting to fetch resource.

xplosionmind avatar Dec 16 '22 08:12 xplosionmind

Thanks for following up on this one. I'm taking another look at it now. @xplosionmind can you tell me what OS you are using (apologies if i asked before).

jacksonh avatar Dec 16 '22 08:12 jacksonh

Thanks for following up on this one. I'm taking another look at it now. @xplosionmind can you tell me what OS you are using (apologies if i asked before).

MacOS 13.1 with LibreWolf 108.0-1

xplosionmind avatar Dec 16 '22 09:12 xplosionmind

Oh LibreWolf is a very good clue. I wonder if a font or some CSS or something is being blocked. Going to see if I can replicate.

jacksonh avatar Dec 16 '22 09:12 jacksonh

Shoot, still can't replicate on that article. This is with LibreWolf

Screen Shot 2022-12-16 at 17 44 21

jacksonh avatar Dec 16 '22 09:12 jacksonh

MacOS 13.1 with LibreWolf 108.0-1

Can you confirm if the issue persist using a different browser? It might be a configuration issue since we can't reliably reproduce it.

Bad3r avatar Dec 16 '22 09:12 Bad3r

Sorry for the late reply. Links styling works on Safari. It is probably a LibreWolf problem.

xplosionmind avatar Dec 20 '22 10:12 xplosionmind

Interesting. I'll keep this open for a bit and try to replicate, it could maybe be something with how our CSS is loaded, but I don't particularly see why it would be blocked, its all coming from the same domain.

jacksonh avatar Dec 20 '22 23:12 jacksonh

Update: links styling for me is not working even in normal Firefox (110.0.1), both on Linux (Ubuntu) and macOS. I disabled all ad blockers.

xplosionmind avatar Mar 14 '23 05:03 xplosionmind

Any chance you have the dark mode extension? Someone else mentioned this is happening with it.

jacksonh avatar Dec 08 '23 08:12 jacksonh

Links underlining works for me in Firefox 121.0 on Fedora 39!

Thanks!

xplosionmind avatar Jan 01 '24 23:01 xplosionmind

Ah awesome, thanks for following up on this one!

jacksonh avatar Jan 02 '24 01:01 jacksonh