jsend icon indicating copy to clipboard operation
jsend copied to clipboard

Published 20 hours ago • verified publisher icon omniti-labs

Change 'fail' to 'failure'

Open dibby-dibby opened this issue 4 years ago • 3 comments

failure is more suitable here, because just like 'success', 'failure' is a noun unlike 'fail' which is a verb.

dibby-dibby avatar Nov 26 '19 11:11 dibby-dibby

I prefer not making this change, as it is has the potential to break existing APIs that check for status: "fail" In addition to its verb usage, fail can be a noun per http://m-w.com/dictionary/fail

sblomberg avatar May 29 '20 17:05 sblomberg

ISTM this is one of those cases where if we were starting from day 1, we might be inclined to go success|failure, but the cost to make the change (aka breaking backwards compatibility) seems higher than the value.

xzilla avatar Aug 13 '20 06:08 xzilla

I prefer "fail" over failure. Although it might seem natural, the first is more understandable.

feyton avatar Jan 14 '22 16:01 feyton