Dan Weber

Results 59 comments of Dan Weber

Yes. A PR would be perfect. On Mon, Jul 20, 2020, 13:41 Lukas Oppermann wrote: > What does "as a patch" mean? Do you mean a "PR" to this repo...

Hey Lukas (@lukasopperman), Np.  Thanks for submitting this. Before I do the deep dive, can you answer these questions? -- Quick Questions/Comments -- 1) Is Puppeteer version 5 a hard...

This is failing before it finishes writing back to the parent process. So it's a genuine bug. Do you mind if we retain a copy of your large image for...

The particular issue is that the output size of the stringified test failure from diff-process is 16205416 bytes which is much larger than the 10MB previously allocated. I'm going to...

@lukasoppermann I've created a pull request with the appropriate fix. Please test it and see how it works for you. On a separate but important note, it's currently using snapshots...

You're welcome. Let's see what we can do about finding a really large PNG file... On Thu, Jul 23, 2020 at 8:06 PM Lukas Oppermann wrote: > Hey @omnisip ,...

Feel free to try this pull request branch without runInProcess and let me know. On Thu, Jul 23, 2020 at 9:45 PM John Hildenbiddle wrote: > @omnisip -- > >...

When I first wrote this, I totally glazed over the fact that the first sample was using a browser -- however -- I'm still interested in hearing feedback on how...

How I use it: jest-image-snapshot + jest-puppeteer-react + storybook (@storybook/react + @storybook/addon-storyshots-puppeteer). We use a component driven development lifecycle that allows us to automatically test and screenshot every component at...