imposm3 icon indicating copy to clipboard operation
imposm3 copied to clipboard

Support for importing non-area relations as MultiLineString

Open talaj opened this issue 7 years ago • 6 comments
trafficstars

It can be convenient to be able to import non-area relations as MultiLineString geometries into linestring table.

This PR adds this capability. Only relations specified in relation_types will be imported. No relations are imported by default.

talaj avatar Oct 26 '18 12:10 talaj

Hi. Thanks for your PR.

The timing is a bit unfortunate as I just made a larger refactoring. Parsing and some basic stuff is moved into a separate library (https://github.com/omniscale/go-osm). The changes are the go-osm branch (https://github.com/omniscale/imposm3/tree/go-osm).

Can you base your patch on this branch and see if you need to make any changes?

For tests: It's great that you included a new system test. But can your use short and commented dummy OSM files like https://github.com/omniscale/imposm3/blob/go-osm/test/route_relation.osm and https://github.com/omniscale/imposm3/blob/go-osm/test/route_relation.osc

olt avatar Nov 09 '18 10:11 olt

Hi @olt. I've rebased it on top of go-osm branch. There were just minor conflicts. The OSM files should be more comprehensible now.

talaj avatar Nov 09 '18 11:11 talaj

@olt Any chance of this being merged? Would be super-useful for me.

komackaj avatar Oct 09 '20 07:10 komackaj

I've rebased it on top of master and changed the base branch to master. Surprisingly, there was no conflict after those two years.

talaj avatar Nov 04 '20 12:11 talaj

@olt I am in the need for that PR. Any reason why it is left unmerged?

farfromrefug avatar Jul 04 '21 09:07 farfromrefug

Sorry for the long silence. Is my understanding correct, that this change is backward incompatible with older imports? (It will try to import multipolygons into linestring tables?)

Can someone who used this patch comment on that?

olt avatar Aug 23 '22 11:08 olt