yii2-scheduling icon indicating copy to clipboard operation
yii2-scheduling copied to clipboard

Add library tests

Open omnilight opened this issue 7 years ago • 8 comments

We need to have tests for the all of the library code.

Also that should be integrated with travisci

omnilight avatar Jun 24 '18 08:06 omnilight

command like tests?

kievo23 avatar Jun 24 '18 10:06 kievo23

As in the first place this package is a port of Laravel's Scheduler, may be good point would be to check their tests:

https://github.com/laravel/framework/blob/master/tests/Console/ConsoleEventSchedulerTest.php https://github.com/laravel/framework/blob/master/tests/Console/Scheduling/EventTest.php https://github.com/laravel/framework/blob/master/tests/Console/Scheduling/CacheSchedulingMutexTest.php

kstkn avatar Jul 11 '18 08:07 kstkn

@omnilight please, take a look at https://github.com/omnilight/yii2-scheduling/pull/31, we can use this approach to port Laravel's tests

kstkn avatar Jul 16 '18 13:07 kstkn

For me - looks good

omnilight avatar Jul 21 '18 10:07 omnilight

Merged #31, will you now integrate travis, @omnilight?

kstkn avatar Aug 09 '18 10:08 kstkn

Let's do it

omnilight avatar Nov 07 '18 17:11 omnilight

@omnilight, I think only you able to do it as owner: https://github.com/marketplace/travis-ci

kstkn avatar Nov 07 '18 20:11 kstkn

@omnilight yup, I can add only my own repos to travis: 2019-04-09_23-13

kstkn avatar Apr 09 '19 21:04 kstkn