node-emoji icon indicating copy to clipboard operation
node-emoji copied to clipboard

emojify() misses some emojis in V2

Open Thomas101 opened this issue 2 years ago • 1 comments

Hi, I've noticed some emojis fail to decode in version 2 vs version 1, despite being listed in emojilib.

Version 2.0.2 emojify(':airplane_departure: and :flashlight:') -> :airplane_departure: and 🔦

Version 1.11.0 emojify(':airplane_departure: and :flashlight:') -> 🛫 and 🔦

It seems pretty consistent, the position in the string etc seems to make no difference.

Thomas101 avatar May 17 '23 08:05 Thomas101

Thanks for the catch! The root issue is that this library is using an older version of emojilib:

https://github.com/omnidan/node-emoji/blob/44800f9262c3a33cc42e0347f333ef33127856d8/package.json#L28

Their 3.X line has newer emojis. So we'll want to switch over.

JoshuaKGoldberg avatar May 18 '23 15:05 JoshuaKGoldberg