omniauth-oauth2 icon indicating copy to clipboard operation
omniauth-oauth2 copied to clipboard
verified publisher icon omniauth

Fix Option `pkce_verifier` Cannot be Set Due to Overwrites

Open berniechiu opened this issue 1 year ago • 2 comments

Hi @BobbyMcWho, thanks for this nice gem.

Description

The option :pkce_verifier, nil is available to be set in the OAuth Strategy configuration. However, it is being overwritten later phase in the #pkce_authorize_params function. We should only assign the default value when it is not set. This PR resolves the issue.

berniechiu avatar Nov 13 '24 09:11 berniechiu

@berniechiu please merge. thanks

tomastrivino avatar Aug 19 '25 01:08 tomastrivino

@tomastrivino Sorry buddy, I cannot merge because I'm not the owner of this gem.

berniechiu avatar Aug 19 '25 01:08 berniechiu