omniauth-ldap icon indicating copy to clipboard operation
omniauth-ldap copied to clipboard

Published 20 hours ago • verified publisher icon omniauth

[wishlist] merge changes from gitlab_omniauth-ldap

Open pravi opened this issue 6 years ago • 3 comments

gitlab_omniauth-ldap was created as a fork when omniauth-ldap was inactive. Now that omniauth-ldap is active again, it makes sense to integrate their changes back into omniauth-ldap and combine efforts. It would be a good idea to give some of them commit access here.

pravi avatar Mar 17 '18 14:03 pravi

At least the changes for lib/omniauth/strategies/ldap.rb and spec/omniauth/strategies/ldap_spec.rb seem very useful.

MrBerg avatar Oct 11 '18 13:10 MrBerg

It seems like GitLab.org development of the fork has moved to https://gitlab.com/gitlab-org/omniauth-ldap since.

MrBerg avatar Oct 12 '18 06:10 MrBerg

@MrBerg you can see this discussion with maintainers of the fork here https://gitlab.com/gitlab-org/gitlab-ce/issues/13280

pravi avatar Oct 12 '18 06:10 pravi