omniauth-ldap icon indicating copy to clipboard operation
omniauth-ldap copied to clipboard

Published 20 hours ago • verified publisher icon omniauth

Add options to retrieve LDAP group membership

Open aocole opened this issue 11 years ago • 7 comments

This change allows the user to configure an additional query that will retrieve the users LDAP group membership and populate it under the "extra" key in the returned auth hash. This is implemented in a way that is very similar to how the filter option was recently implemented. Tests and updated README included.

aocole avatar Jan 21 '14 01:01 aocole

+1. Any chance this is going to get merged?

sammarx avatar Nov 17 '15 22:11 sammarx

Same question, only 3 years later. This is a necessary feature.

MrBerg avatar Oct 11 '18 12:10 MrBerg

Hello all,

Happy to help in terms of making sure this happens. I agree that this is an absolutely essential feature in modern LDAP. What's the good of LDAP for a larger operation if groups cannot be moved over as well?

Any comments from the maintainers?

tareko avatar Oct 31 '18 13:10 tareko

Same question, only again ~2 years later. What needs to be done to merge this PR ?

vchrizz avatar Jul 12 '20 01:07 vchrizz

@tmilewski @miketierney @ Maintainers Are you willing to accept such a pull request? The functionality to sync groups would be helpful for many plugins such as discourse-ldap-auth. If so, I can provide an updated patch set.

ghost avatar Mar 03 '22 13:03 ghost

At the moment I see this message:

This branch has conflicts that must be resolved Only those with write access to this repository can merge pull requests.

So I guess this PR needs to be adapted for correct merge, @aocole would you update your pull request as it's already 8 years old? In the hope maintainers would merge it.

vchrizz avatar Mar 03 '22 23:03 vchrizz

So I guess this PR needs to be adapted for correct merge, @aocole would you update your pull request as it's already 8 years old? In the hope maintainers would merge it.

@vchrizz I'm no longer at @hpcloud and I don't have write access to the repo to update this PR. Sorry! You're welcome to take the code do it if you're interested!

aocole avatar Mar 04 '22 02:03 aocole

Happy 10 year anniversary #43!!!

ingydotnet avatar Jan 20 '24 18:01 ingydotnet

Wow, 10 years. Hard to believe. There are so many people I want to thank. First of all, obviously, Omniauth and the omniauth-ldap library for being my inspiration and my rock through all of this. Without you this PR never could have stayed open this long. Also have to thank HP Cloud for paying me to do this work originally. Shout out to @ingydotnet and Jeff Hobbs (hey ActiveState folks!) for getting me connected to that job. And finally, to all the commenters and fans on this PR over the years - thank you! I dedicate this to you.

aocole avatar Jan 20 '24 19:01 aocole