omise-ruby

omise-ruby copied to clipboard

Hi when `Omise::Token.create` method is succeed, it returns json but when failed, it returns text format so it causes JSON::Parser error on my rspec ```` JSON::ParserError: 822: unexpected token at...

saiqulhaq

Karn2544 Create SECURITY.md

1

## Description *NOTE:* * **Optional**: Update any additional information in the `More Information` section, as appropriate. ### More information (if any) ### Documentation (if any) ### Related links: - Issue...

thicha10

Could you use JSON.parse instead of JSON.load?

3

### Expected behavior JSON.parse usage (bad template; there is no place to provide a proper explanation. will comment later) ### Actual behavior JSON.load usage (bad template; there is no place...

midnight-wonderer

## Description - Issue ID: https://github.com/omise/omise-ruby/issues/60 ## Decision(s) `JSON.load` does not raise rescue-friendly errors. (See https://github.com/omise/omise-ruby/issues/60.) Use `JSON.parse` like everyone else. ## Business impact (if any) When the exception is...

midnight-wonderer