gltf-extensions icon indicating copy to clipboard operation
gltf-extensions copied to clipboard

Change capsules and cylinders to have separate top and bottom radiuses

Open aaronfranke opened this issue 5 months ago • 0 comments

This PR changes the OMI_physics_shape definition of a capsule and cylinder to have radiusBottom and radiusTop properties, which matches the KHR_collision_shapes extension. This PR also changes the capsule's height property to refer to the mid height instead of the full height, which also matches KHR_collision_shapes.

https://github.com/eoineoineoin/glTF_Physics/blob/master/extensions/2.0/Khronos/KHR_collision_shapes/schema/glTF.KHR_collision_shapes.shape.capsule.schema.json

https://github.com/eoineoineoin/glTF_Physics/blob/master/extensions/2.0/Khronos/KHR_collision_shapes/schema/glTF.KHR_collision_shapes.shape.cylinder.schema.json

I was initially against this since it seemed that no game engine or physics engine supported it, but Jolt added support for both of these things recently, and they are going to be added to Godot Engine soon. Still, these will have to be approximated using convex hulls when being imported into Unity, Unreal Engine, and more.

aaronfranke avatar Sep 12 '24 11:09 aaronfranke