Omid Rad

Isn't Enum better for WorkingKeys?

2

It looks like WorkingKeys can be an Enum. And so [`state.working_keys`](https://github.com/pouriya/sssh/blob/23.03.05/src/subcommands/select.rs#L176) can be a simple array, or if you insist for the uniqueness, it can be a BTreeSet.

Clippy is your mate

2

Clippy is your mate, even if you sleep with it `nightly`!

[Discussion] convert all `Option<String>` params to `Option<&str>`

1

Currently, all string params are `Option` (57 occurrences). What do you think of switching all with `Option`? `auth_client: Option,` instead of `auth_client: Option,`.

To continue the discussion [here](https://github.com/kilork/keycloak/pull/7) and [here](https://github.com/kilork/keycloak/pull/16)... AFAIK, the main `grant_type`s for this case are `password` and `client_credentials`. For `password`, based on [this](https://www.oauth.com/oauth2-servers/access-tokens/password-grant/) article, we need `username` and `password` mostly....

`KeycloakServiceAccountAdminTokenRetriever` vs `KeycloakAdminToken`

3

Better to follow the same pattern for both structs. One has `acquire` the other one has `create`. One the `get` sends a request always, in the other one uses the...

Similar to `objectify`, to return `Map`

4

Sometimes it's [recommended](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map#objects_vs._maps) to use [`Map`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map) instead of `Record`, and the keys are not limited to `number | string | symbol`. So it makes sense to have another set of...

Support otel 0.24

1

`opentelemetry-jaeger` is deprecated and reached eol. ([More](https://crates.io/crates/opentelemetry-jaeger) [info](https://opentelemetry.io/blog/2022/jaeger-native-otlp/))

Fixes #184

- Add no_cache function to io_cached and once - Add `attributes` to prime function of all types - Add `generics` to some/all missing places - Remove some duplicate codes

`io_cached` doesn't have `result` and `option` flags

1

Is there any reason for this?