Omer Morad

Results 39 comments of Omer Morad

@jmcdo29 @kamilmysliwiec I'm still working on this one, I have tons of work in my workplace, but I believe I will finish this one soon. @kamilmysliwiec in the meanwhile, I...

@TimothyJones CI fails: `PactBroker::Client::Error - Command 'git rev-parse --abbrev-ref HEAD' didn't return anything that could be identified as the current branch.` Can you help?

> That's a problem that happens on PR builds at the moment, you can safely ignore it (the windows build works fine). **I'm going to create a PR to fix...

> Hey @omermorad, the build errors should be all resolved now, is there any chance you could get some time to look at [omermorad/nestjs-pact#7](https://github.com/omermorad/nestjs-pact/issues/7) > > If you don't have...

Keep on doing that, we need some fresh air sometimes :) I didn't get to it yet, but until I will - if you have a chance to add a...

@arthurfiorette what version are you using? Can you try it with [3.0.0-rc.3](https://www.npmjs.com/package/mockingbird/v/3.0.0-rc.3)?

Yes, it's been tested with a new integration test, look here: https://github.com/omermorad/mockingbird/blob/mockingbird%403.0.0-rc.3/packages/parser/test/integration/common/test-classes.ts, those are all actual classes that are being tested (simulates a real situation). I belive I will release...

Got you! Thanks a lot, @arthurfiorette. Don't be sorry, it's our job to make improve this library over time :)

> Also, if i use `null` or `undefined` as the `@Mock(() => result)`, it throws: > > ``` > TypeError: Cannot convert undefined or null to object > at Function.getOwnPropertyNames...

Thanks! Will change it soon