Clarify "restrict" behaviour on sites

[allanaaa]

https://github.com/omeka/omeka-s/blob/b46e5b061872c27f5ad6bf02bf1daf40cb0ff0f5/application/src/Form/SiteSettingsForm.php#L182

Can we change the text of "Restrict browse to attached items" to "Restrict browsing to items attached to pages" or "Browsing only shows items included in pages" or something a bit more specific? Alternatively/additionally, include an info text that clarifies that setting. "If checked, users will not be able to view items that have not been included on pages in this site."

I feel like it's a bit vague as to what "attached" means. Based on testing, it means:

• Item showcase
• Item with metadata
• Item carousel
• Map with attachments
• Media embed (its item will be included).

Whereas a page with a map that has a query ... will display all the items included as resources on the site, not just those items in the browsing counts. So that's not restricted. That might need changing: the map query should only look within browseable items, not all resources.

[zerocrates]

This is also a feature that just generally doesn't make as much sense now, when you can directly pick and choose what's included as a resource, as it did under the old search-based "item pool" system.

[jimsafley]

The browse_attached_items setting dictates whether an API search includes the site_attachments_only flag. Definitely a vestige of the previous pool system. It's not something we can remove without breaking BC, but I think it's a good idea to clarify what the setting does, as @allanaaa mentions above.

As far as I know, we've never had a complaint about the behavior of the "Map by query" block. Perhaps it's because no one's ever used them together.

[zerocrates]

I'm increasingly of a mind to just remove this, but that will have to wait for a major release.

In the meantime maybe saying "(legacy)" or something in its label may be appropriate, possibly in addition to a label change? I have a sense that most people we see with this turned on are just clicking it because it seems like a good idea.

Side note, we did just have someone note the different behavior between the map query block and a browse preview block with this setting on, though it wasn't a complaint per se, more of just one more source of confusion.